Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SkipFinalSnapshot on delete #101

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Implement SkipFinalSnapshot on delete #101

merged 5 commits into from
Jan 24, 2022

Conversation

liskl
Copy link
Contributor

@liskl liskl commented Jan 2, 2022 •
edited
Loading

  • update for FinalSnapshot Functionality in RDS, thanks @amazzalel-habib
  • update to go v1.17
  • updated dependencies

liskl and others added 4 commits January 2, 2022 09:49
@liskl @wgarunap
aws-go-sdk-v2 upgrade to v1.3.0 (#3)
14464db 
* github.com/aws/aws-sdk-go-v2 dependency updated from v0.11.0 to v1.3.0

Massive thanks for the help @wgarunap

Co-authored-by: loren lisk <loren.lisk@foghornonsulting.com>
Co-authored-by: Aruna Prabashwara <wg.aruna.p@gmail.com>
@liskl
- update for FinalSnapshot Functionality in RDS
a91815b 
- update to go v1.17
- updated dependancies
@liskl
move dockerfile to golang:1.17.0-alpine
136b485
@liskl
fixing golangci-lint
2e5b5da
@liskl liskl force-pushed the amazzalel-habib-implement-finaldbsnapshot-on-delete branch from a30a53d to 2e5b5da Compare January 2, 2022 23:57
@liskl liskl changed the title Amazzalel habib implement finaldbsnapshot on delete implement finaldbsnapshot on delete Jan 2, 2022
@liskl liskl changed the title implement finaldbsnapshot on delete Implement SkipFinalSnapshot on delete Jan 3, 2022
@liskl
Copy link
Contributor Author

liskl commented Jan 3, 2022

@sorenmat would you be able to review this?

sorenmat
sorenmat reviewed Jan 3, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
@liskl liskl requested a review from sorenmat January 3, 2022 12:11
@liskl
Copy link
Contributor Author

liskl commented Jan 4, 2022

Sorry for the wasted time on the first one, I'll get better I swear, care to try for a second review @sorenmat ?

sorenmat
sorenmat approved these changes Jan 24, 2022
View reviewed changes
Copy link
Owner

@sorenmat sorenmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenmat sorenmat merged commit d2b43a4 into sorenmat:master Jan 24, 2022
@sorenmat sorenmat mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenmat sorenmat sorenmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liskl @sorenmat