Added fix to enable asynchronous loading in IE (fixes #171 and #175) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a reason why document.write was used. There was a certain case which caused IE (7?) to fail miserably. Sadly enough there are no tests and I can't recall what caused the issue. But it might have been related to frames and/or stand-alone IE installs. That's why nothing has been done about it earlier. But now that I think about it, if we apply this patch and something breaks, at least we'll once again know what the cause was. Which would be nice. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed "document.write" in favor of "document.createElement" to enable asynchronous loading. Tested in IE7-9.