-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #461 - 신규 홈뷰 - 방문자 전용 UI 구현 #464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
폴더 위치 변경
|
yungu0010
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 고생하셨습니당!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
(방문자 전용) 신규 홈뷰의 UI를 구현합니다.
🌱 작업한 브랜치
🌱 PR Point
DashBoard 섹션 분리
AS-IS
: 기존에는DashBoardHeader
와CalendarItem
으로 구성되어 있었는데, 방문자 전용 뷰에서CalendarItem
이 사용되지 않는 경우가 생겨DashBoardHeader
를 Cell로 변경하게 되었습니다.TO-BE
:Header
를Cell Item
으로 변경하면서DashBoard
섹션을DashBoard
,Calendar
두 개의 섹션으로 분리했습니다.📌 참고 사항
Main Product
아이템들 로고 이미지 사이즈가 조금씩 달라보이는데, 디자인에 이미지 크기 통일해달라고 요청한 상태입니다. 답변 오는대로 수정해놓겠습니다! -> 수정했습니다!📸 스크린샷
📮 관련 이슈