Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #402 - 솝마디 앰플리튜드 이벤트 추가 #404

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[Feat] #402 - 솝마디 앰플리튜드 이벤트 추가 #404

merged 3 commits into from
Oct 16, 2024

Conversation

yungu0010
Copy link
Contributor

@yungu0010 yungu0010 commented Oct 16, 2024 •
edited
Loading

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 솝마디 앰플리튜드 이벤트를 추가했습니다.

📌 참고 사항

send_choice에서 key값을 하드코딩하고 있는데, 마감기한으로,, 추후 AmplitudeEventPropertyKey로 변경하도록 하겠습니다 ! !

📸 스크린샷

기능 스크린샷
앰플리튜드 로그 image

📮 관련 이슈

@yungu0010 yungu0010 added Feat 새로운 기능 구현 윤서🍉 labels Oct 16, 2024
@yungu0010 yungu0010 requested a review from dlwogus0128 October 16, 2024 08:05
@yungu0010 yungu0010 self-assigned this Oct 16, 2024
@height Height
Copy link

height bot commented Oct 16, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

dlwogus0128
dlwogus0128 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

윤서핑 수고핑 💕

...es/DailySoptuneFeature/Sources/DailySoptuneScene/ViewModel/DailySoptuneResultViewModel.swift
@@ -67,21 +74,25 @@ extension DailySoptuneResultViewModel {
.withUnretained(self)
.sink { owner, _ in
owner.onNaviBackButtonTapped?()
AmplitudeInstance.shared.track(eventType: .clickLeaveSoptuneResult)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 식으로 쓰는 거군요!! 나중에 이벤트 트래킹 추가할 때 참고하겠습니다 👀

@yungu0010 yungu0010 merged commit df74be2 into develop Oct 16, 2024
@yungu0010 yungu0010 deleted the feat/#402-SoptuneAmplitude branch October 16, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwogus0128 dlwogus0128 dlwogus0128 approved these changes

Assignees

@yungu0010 yungu0010

Labels
Feat 새로운 기능 구현 size/M 윤서🍉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 솝마디 앰플리튜드 이벤트 추가
2 participants
@yungu0010 @dlwogus0128