[Fix] #395 - 딥링크 변경 사항 반영 및 baseURL trailing slash 수정 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dlwogus0128
approved these changes
Oct 1, 2024
| make.top.equalTo(view.safeAreaLayoutGuide).offset(2.adjustedH) | ||
| make.leading.equalToSuperview().inset(8.adjusted) | ||
| make.top.equalTo(view.safeAreaLayoutGuide).offset(2) | ||
| make.leading.equalToSuperview().inset(8) | ||
| make.size.equalTo(40) |
|
|
||
| return coordinator | ||
| } | ||
|
|
||
| @discardableResult |
| public var isDestination = false | ||
|
|
||
| public func execute(with coordinator: Coordinator, queryItems: [URLQueryItem]?) -> Coordinator? { | ||
| guard let coordinator = coordinator as? DailySoptuneCoordinator else { return nil } | ||
| guard let coordinator = coordinator as? ApplicationCoordinator else { return nil } | ||
|
|
| @@ -52,7 +52,8 @@ open class BaseService<Target: TargetType> { | |||
| }() | |||
|
|
|||
| private let endpointClosure = { (target: API) -> Endpoint in | |||
| let url = target.baseURL.appendingPathComponent(target.path).absoluteString | |||
| let url = target.path.isEmpty ? target.baseURL.absoluteString : target.baseURL.appendingPathComponent(target.path).absoluteString | |||
|
|
|||
| var endpoint: Endpoint = Endpoint(url: url, | |||
There was a problem hiding this comment.
요걸 바로 발견하구 . 해결해버링 . 짱짱 개발자
| @@ -45,7 +45,7 @@ extension DefaultDailySoptuneUseCase: DailySoptuneUseCase { | |||
| .withUnretained(self) | |||
| .sink { event in | |||
| print("GetDailySoptuneResult State: \(event)") | |||
| } receiveValue: { _, resultModel in | |||
| } receiveValue: { owner, resultModel in | |||
There was a problem hiding this comment.
혹시 어떤 방식이 더 편하신가요 ? 기존 코드를 보니 withUnretained와 guard let이 혼재되어서 이번 기회에 하나로 통합하면 좋을 것 같아서요 !!
There was a problem hiding this comment.
withUnretained를 써주는 게 가독성면에서 더 조을 것 같아서..! 이 쪽으로 통합했으면 좋겠습니다 !-!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
딥링크 코드 수정
baseURL trailing slash 오류 해결
/가 자동으로 추가되는 문제가 있어 Moya의 URL+Moya 파일을 참고하여 수정했어요.솝마디 뷰 레이아웃 수정
📸 스크린샷
📮 관련 이슈