Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #383 - 솝마디 타이틀, 부적화면 UI 구현 #387

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

yungu0010
Copy link
Contributor

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 솝마디 타이틀과 부적화면 UI를 구현했습니다.
  • 부적화면에 사용되는 OutlinedButton을 구현했습니다.

📌 참고 사항

  • 솝마디 타이틀과 결과 뷰에서 사용되는 버튼에 폰트를 지정하는 함수를 추가해두었습니다 ! 혹시 결과 뷰에서 하단버튼 폰트를 지정하지 않으셨다면 .setFontColor사용하시면 될 것 같아요 ~! @dlwogus0128
  • 부적화면에 label 색상과 이미지는 API 통신 시 함께 작업 해야할 것 같아 별도로 작업하지 않았습니다 !-!

📸 스크린샷

기능 스크린샷
솝마디 타이틀
솝마디 부적화면

📮 관련 이슈

Copy link

height bot commented Sep 25, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ♡✧。

}

private let checkTodayFortuneButton = AppCustomButton(title: I18N.DailySoptune.checkTodayFortune)
.setFontColor(customFont: DSKitFontFamily.Suit.semiBold.font(size: 18))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앟 지금 보니까 저도 폰트가 다르네효.. 활용해서 고치겠습니다 ~~

@@ -41,6 +41,19 @@ extension AppCustomButton {
self.setAttributedTitle(string, for: .normal)
return self
}

@discardableResult
public func setFontColor(customFont: UIFont, customColor: UIColor = DSKitAsset.Colors.black100.color) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쪼아요

@yungu0010 yungu0010 merged commit f64cdcd into develop Sep 26, 2024
@yungu0010 yungu0010 deleted the feat/#383-DailySoptune branch September 26, 2024 04:15
Copy link

@seungchan2 seungchan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

view.backgroundColor = DSKitAsset.Colors.semanticBackground.color
}

private func setLayout() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private extension DailySoptuneMainVC {
  func setUI() {}
  func setLayout() {}
}

취향 차이용!


import UIKit

public class AppOutlinedButton: UIButton {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상속해서 쓰나요?!

@yungu0010 yungu0010 self-assigned this Sep 27, 2024
@yungu0010 yungu0010 added Feat 새로운 기능 구현 윤서🍉 labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/L 윤서🍉
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 솝마디 타이틀, 부적화면 UI 구현
3 participants