Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping support for symfony < 3.4 #272

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Dropping support for symfony < 3.4 #272

merged 1 commit into from
Dec 4, 2019

Conversation

franmomu
Copy link
Member

Subject

This is the same thing as sonata-project/SonataAdminBundle#5733, dropping support of Symfony < 3.4 and >= 4, < 4.2

I am targeting this branch, because these changes respect BC.

Changelog

### Removed
- Support for Symfony < 3.4
- Support for Symfony >= 4, < 4.2

@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from 67663bb to 39dc43d Compare November 11, 2019 18:08
@franmomu franmomu mentioned this pull request Nov 11, 2019
Merged
18 tasks
@phansys phansys added the minor label Nov 11, 2019
@phansys phansys requested a review from a team November 11, 2019 18:34
phansys
phansys reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, from a strict perspective, removing classes or public services are not BC changes.

@franmomu
Copy link
Member Author

IMO, from a strict perspective, removing classes or public services are not BC changes.

I'll revisit when I finish with the other ones and mark them as deprecated. They are not supposed to be used, but you're right.

@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from 39dc43d to 09253b6 Compare November 12, 2019 16:04
core23
core23 previously approved these changes Nov 12, 2019
View reviewed changes
@greg0ire greg0ire force-pushed the drop_symfony_support_less_than3_4 branch from 09253b6 to 278cee7 Compare November 12, 2019 18:43
@greg0ire
Copy link
Contributor

I just fixed the cs issue

@greg0ire
Copy link
Contributor

The remaining failure is due to user 3 require sf 2.8. We should remove that line from the build matrix in dev-kit

@greg0ire
Copy link
Contributor

Blocked by sonata-project/dev-kit#516

@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from 278cee7 to ce130fe Compare November 13, 2019 08:26
core23
core23 previously approved these changes Nov 13, 2019
View reviewed changes
@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from ce130fe to 2fd0183 Compare November 14, 2019 22:08
@phansys
Copy link
Member

phansys commented Nov 22, 2019

Blocked by sonata-project/dev-kit#516

This is not blocking the PR anymore.
But now we have another problem:

1) Sonata\IntlBundle\Tests\Helper\LocaleHelperTest::testLanguage
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'anglais américain'
+'anglais'
/home/travis/build/sonata-project/SonataIntlBundle/tests/Helper/LocaleHelperTest.php:41
FAILURES!
Tests: 45, Assertions: 120, Failures: 1.

core23
core23 previously approved these changes Nov 22, 2019
View reviewed changes
@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch 2 times, most recently from 9da9b2b to cefb953 Compare November 22, 2019 22:30
core23
core23 previously approved these changes Nov 22, 2019
View reviewed changes
@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from cefb953 to 5a3ad84 Compare November 22, 2019 22:34
@franmomu
Copy link
Member Author

Apparently is because of symfony/symfony#33148, with the Languages class is works.

@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch 2 times, most recently from acd91c8 to e66b234 Compare December 4, 2019 01:28
@franmomu franmomu force-pushed the drop_symfony_support_less_than3_4 branch from e66b234 to 97f0866 Compare December 4, 2019 01:44
@greg0ire greg0ire merged commit 03255d2 into sonata-project:2.x Dec 4, 2019
@greg0ire
Copy link
Contributor

greg0ire commented Dec 4, 2019

Thanks @franmomu !

@franmomu franmomu deleted the drop_symfony_support_less_than3_4 branch December 4, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire left review comments

@core23 core23 core23 approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franmomu @greg0ire @phansys @core23