Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CO₂ emissions factor configurable #3290

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

suprnova32
Copy link
Contributor

I love the CO₂ reduction feature, but it is not configurable, and set to the German factor, which is, to be honest, quite high (thanks Grünen).

This PR allows the factor to be set as an ENV variable. Ideally it would work just as the energy prices, with a set start date for the calculations, so that you can update it when new energy sources are introduced, but that is too much work for now. I might look further into in the future, but for the time being this works.

Also fixes a typo with the constant name.

@suprnova32
Copy link
Contributor Author

I just became aware of #3198, now that would be the absolute best approach. In the meantime I still think this helps, specially for me since electricity maps has no data for Ecuador 😅

@ledermann ledermann merged commit a046b33 into solectrus:develop Jul 25, 2024
4 checks passed
@ledermann
Copy link
Member

Cool stuff, thanks for contribution 👍 This is a good fallback option if electricitymaps doesn’t have data for a specific country.

By the way, I’m impressed that SOLECTRUS has already reached Ecuador in its quest for world domination ;-)

ledermann added a commit that referenced this pull request Jul 25, 2024
ledermann added a commit that referenced this pull request Jul 25, 2024
ledermann added a commit that referenced this pull request Jul 25, 2024
@ledermann ledermann added this to the 0.15.1 milestone Jul 25, 2024
@suprnova32
Copy link
Contributor Author

😂 yes! I became aware of it via the forecast.solar website. they have a logo of the project on it, and I was curious to know more about it. I love the simplicity and cleanliness of the dashboard. It has all the information I need at a glance. I have access to more granular data, and to other graphing options via Grafana, but seeing the most relevant information displayed without distractions is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants