[CMake] SofaMacros.cmake: deprecating sofa_create_package #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sofa_generate_package (Named arguments)
marques-bruno
added
enhancement
|
I fully agree with the systematic use of name argument in CMake macros. |
epernod
reviewed
Feb 3, 2019
damienmarchal
approved these changes
Feb 5, 2019
guparan
added
pr: status wip
|
[ci-build][with-scene-tests][with-regression-tests] |
marques-bruno
added
pr: status ready
guparan
pushed a commit
to guparan/sofa
that referenced
this pull request
Feb 19, 2019
…package [CMake] SofaMacros.cmake: deprecating sofa_create_package # Conflicts: # SofaKernel/SofaFramework/SofaMacros.cmake # modules/SofaSparseSolver/CMakeLists.txt
6 tasks
guparan
pushed a commit
to guparan/sofa
that referenced
this pull request
Feb 26, 2019
…package [CMake] SofaMacros.cmake: deprecating sofa_create_package # Conflicts: # SofaKernel/SofaFramework/SofaMacros.cmake # modules/SofaSparseSolver/CMakeLists.txt
alxbilger
pushed a commit
to alxbilger/sofa
that referenced
this pull request
Oct 27, 2023
…package [CMake] SofaMacros.cmake: deprecating sofa_create_package # Conflicts: # SofaKernel/SofaFramework/SofaMacros.cmake # modules/SofaSparseSolver/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of a new sofa_generate_package function (with named arguments)
It's never clear what the arguments passed to this function are for. Now you have to know to use it :)
This PR:
Reviewers will merge only if all these checks are true.