Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscFem] Clean BaseMaterial::handleTopologyChange #817

Merged
merged 1 commit into from
Nov 16, 2018
Merged

[SofaMiscFem] Clean BaseMaterial::handleTopologyChange #817

merged 1 commit into from
Nov 16, 2018

Conversation

agpetit
Copy link
Contributor

@agpetit agpetit commented Nov 8, 2018

small PR to remove function handleTopologyChange() from BaseMaterial component, where it is implemented but empty.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 12, 2018
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 14, 2018
@epernod epernod merged commit 5c8f28e into sofa-framework:master Nov 16, 2018
@guparan guparan added this to the v18.12 milestone Dec 17, 2018
@guparan guparan changed the title clean handleTopologyChange [SofaMiscFem] Clean BaseMaterial::handleTopologyChange Dec 17, 2018
@pedroperrusi pedroperrusi deleted the clean_handleTopologyChange branch April 16, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
4 participants
@agpetit @guparan @hugtalbot @epernod