Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine #814

Merged
merged 8 commits into from
Nov 21, 2018
Merged

[SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine #814

merged 8 commits into from
Nov 21, 2018

Conversation

marques-bruno
Copy link
Member

@marques-bruno marques-bruno commented Nov 8, 2018 •
edited by guparan
Loading

Fix #809
Following the STC decision to replace the DataEngine with the SimpleDataEngine, here's the PR that does just that.

This replacement involves taking every engine in Sofa and:

  • replacing its update() method with the new delegate doUpdate().
  • Remove the calls to data.isDirty() and (smartly) replacing them with m_dataTracker.isDirty(data)
  • Remove the cleanDirty() calls while making sure we don't break the engine's behavior

Most engines present in SOFA are either in SofaGeneralEngine or SofaMiscEngine.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added enhancement About a possible enhancement pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress labels Nov 8, 2018
@marques-bruno marques-bruno added this to the v18.12 milestone Nov 8, 2018
@marques-bruno marques-bruno added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 8, 2018
@marques-bruno
Copy link
Member Author

Default CMake build compiles, now all the plugins, and disabled options that activate code using DataEngines need to be activated to propagate that change.
I'm counting on you...!

@marques-bruno marques-bruno mentioned this pull request Nov 8, 2018
Closed
6 tasks
@marques-bruno marques-bruno mentioned this pull request Nov 9, 2018
Merged
6 tasks
@marques-bruno
Copy link
Member Author

[ci-build]

@guparan
Copy link
Contributor

guparan commented Nov 14, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 20, 2018
@guparan guparan merged commit 2a1a434 into master Nov 21, 2018
@guparan guparan changed the title [Data Update] [SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine [SofaKernel] BREAKING: Replacing DataEngine with SimpleDataEngine Nov 21, 2018
untereiner pushed a commit to mimesis-inria/sofa that referenced this pull request Nov 23, 2018
[SofaCombinatorialMaps] update function change (see sofa-framework#814)
237736a
@guparan guparan deleted the simplerDataEngine branch September 18, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

@epernod epernod Awaiting requested review from epernod

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: breaking Change possibly inducing a compilation error pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
2 participants
@marques-bruno @guparan