Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geomagic] Fix broken behavior #761

Merged
merged 2 commits into from
Sep 6, 2018
Merged

[Geomagic] Fix broken behavior #761

merged 2 commits into from
Sep 6, 2018

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Aug 30, 2018 •
edited
Loading

Fix one of the bugs breaking the Geomagic behavior.

When updating the position of the Omni visual node, visitor update was call on the Omni->getContext() which is usually the Root node, thus all node where updated outside of the normal mechanical step leading to bad physic behavior.
Call the update on the Omni visual node only.

  • some small change and warning fix.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added 2 commits August 30, 2018 17:33
@epernod
[Geomagic plugin] Clean some compilation warnings.
37b8a77
@epernod
[Geomagic plugin] Fix: visitor update need to be called on the omni v…
d2ae194 
…isual node and not the getContext as this can be the root and thus update all the node in the scenes. Update the name of the omni node for more clarity.
@epernod epernod added location: plugins pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Aug 30, 2018
@epernod epernod self-assigned this Aug 30, 2018
@epernod epernod requested a review from hugtalbot August 30, 2018 15:40
@guparan guparan changed the title [Geomagic Plugin] Fix broken behavior [Geomagic] Fix broken behavior Aug 30, 2018
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 4, 2018
@guparan guparan merged commit 20a079d into sofa-framework:master Sep 6, 2018
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
2 participants
@epernod @guparan