Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGraphComponent] FIX SceneChecker_test + ADD alias test #711

Merged
merged 2 commits into from
Jul 13, 2018
Merged

[SofaGraphComponent] FIX SceneChecker_test + ADD alias test #711

merged 2 commits into from
Jul 13, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Jul 12, 2018 •
edited by epernod
Loading

2 more tests 😉

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 12, 2018
@guparan guparan added this to the v18.06 milestone Jul 12, 2018
@guparan guparan requested a review from damienmarchal July 12, 2018 13:27
@guparan
Copy link
Contributor Author

guparan commented Jul 12, 2018 •
edited
Loading

[ci-build] (scene tests not needed)

@epernod epernod merged commit 5140862 into sofa-framework:master Jul 13, 2018
@guparan guparan deleted the fix_checkmissingplugin_test branch October 1, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @epernod