-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseTopology Test] Add battery of tests on topology containers #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…triangleSetTopologyContainer. For the moment only test all buffer creation: triangle, edge, vertices and also cross buffer, TriangleAround vertex/edge and edgesInTriangle.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints.
…SetTopologyContainer. For the moment only test all buffer creation: edge, vertices and also cross buffer, EdgeAroundVertex.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints. Fix for quad, tetra et hedra
…SetTopologyContainer. For the moment only test all buffer creation: quad, edge, vertices and also cross buffer, QuadAround vertex/edge and edgesInQuads.
…test class to test their TopologyContainer. For the moment only test all buffer creation: hexahedron/tetrahedron, quad/triangle, edge, vertices and also cross buffer, hexahedronAround Quad and Vertices, Quad and edge in Hexahedron and same for triangles with tetrahedron. FIX: some loop limit bug ADD: cube small mesh in tetrahedron and square1 in quads.
… were in protected. Put them in public.
…t a MeshTopology instead of dynamic containers. Add: MestTopology_test where most common getter are tested and the all topology buffers are compare to the dynamic_container one, assuming that the tests on the dynamic topology are already testing the topology itself.
epernod
added
location: tests
pr: status wip
Development in the pull-request is still in progress
pr: clean
Cleaning the code
labels
Jul 6, 2018
Several tests are not passing yet due to error in the code to be fixed soon. |
I cannot support more what you are doing, thanks Erik ! |
…aRepository + macro to source path + resources
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jul 10, 2018
…de of bounds, if outside return an element filled with -1 values
…to have the good number of points in the topology.
[ci-build][with-scene-tests] |
…l between MeshTopology and topoContainer. Not sure if one version is better than the other.
[ci-build][with-scene-tests] |
…Problem of topological Mapping need ot be solved first.
…Problem of topological Mapping need ot be solved first.
… is filled like dynamic topo. Disable some deletion in the removeTetra2Triangle process. Will solve this problem later.
[ci-build][with-scene-tests] |
guparan
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as promised since long time ago...
There is still a lot of work to do but here is a first set of tests on the topology containers.
it is just the beginning !
FIX #43
This PR:
Reviewers will merge only if all these checks are true.