Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Remove unused function "renumberConstraintId" #691

Merged
merged 2 commits into from
Jul 3, 2018
Merged

[SofaKernel] Remove unused function "renumberConstraintId" #691

merged 2 commits into from
Jul 3, 2018

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Jun 19, 2018 •
edited by guparan
Loading

This is reopening one PR that was issued from SofaDefrost/master instead of a dedicated branch.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal mentioned this pull request Jun 19, 2018
Closed
6 tasks
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 27, 2018
@hugtalbot hugtalbot changed the title Remove unused function "renumberConstraintId" [SofaKernel] Remove unused function "renumberConstraintId" Jun 27, 2018
@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Jun 27, 2018
@hugtalbot hugtalbot removed pr: status ready Approved a pull-request, ready to be squashed pr: status to review To notify reviewers to review this pull-request labels Jun 27, 2018
@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Jun 27, 2018
@guparan guparan merged commit a70535b into sofa-framework:master Jul 3, 2018
@guparan guparan added this to the v18.06 milestone Jul 12, 2018
@damienmarchal damienmarchal deleted the Sofa_removeUnneededCode branch August 6, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
4 participants
@damienmarchal @guparan @hugtalbot @ChristianDuriez