Modularizing config.h #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently config.h is a all-in-one configuration file that is generated by CMakeLists and included nearly everywhere. The problem is that it contains also very specific options that very few files are using. But, each time any of these specific option is changed sofa needs to be recompiled entirely. This PR is a implementing a more specific approach in which each .cpp that specifically requires a given define a dedicated file. Eg: #include<config/build_option_opengl.h> // to do #if(SOFA_WITH_OPENGL==1) or #include<config/build_option_experimental.h> // to do #if(SOFA_WITH_EXPERIMENTALFATURE==1) or #include<config/sharedlibrary_defines.h> ... it is still possible to use the old file but by being more specific we will reduce the amount of file to recompile when we will changed something.
damienmarchal
added
pr: fast merge
|
👍 for this work |
guparan
reviewed
Oct 23, 2017
| #include <sofa/config/sharedlibrary_defines.h> | ||
| #include <sofa/config/build_option_dump_visitor.h> | ||
| #include <sofa/config/build_option_opengl.h> | ||
| #include <sofa/config/build_option_threading.h> |
There was a problem hiding this comment.
Do you think we should deprecate this? When?
There was a problem hiding this comment.
I don't know. But would prefer to focus of task with more added value :)
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently config.h is a all-in-one configuration file that is generated by CMakeLists and included nearly everywhere. The problem is that it contains also very specific options that very few files are using. But, each time any of these specific option is changed sofa needs to be recompiled entirely.
This PR is a implementing a more modular approach in which each .cpp that specifically requires a given define include a dedicated file.
Eg:
#include<config/build_option_opengl.h> // to do #if(SOFA_WITH_OPENGL==1)
or
#include<config/build_option_experimental.h> // to do #if(SOFA_WITH_EXPERIMENTALFATURE==1)
or
#include<config/sharedlibrary_defines.h>
It is still possible to use the old file but by being more specific we will reduce the amount of file to recompile when we will changed something.
This PR:
Reviewers will merge only if all these checks are true.