Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMisc] Add a data repository at start-up time #402

Merged
merged 6 commits into from
Sep 22, 2017
Merged

[SofaMisc] Add a data repository at start-up time #402

merged 6 commits into from
Sep 22, 2017

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 14, 2017 •
edited by damienmarchal
Loading

A small utility object to add a repo at runtime.
Check the example for getting an idea on how to use.

I guess it would be mainly useful for people still using XML scene...

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added the enhancement About a possible enhancement label Sep 14, 2017
@fredroy fredroy requested a review from hugtalbot September 14, 2017 13:20
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request labels Sep 14, 2017
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Sep 15, 2017
guparan
guparan suggested changes Sep 18, 2017
View reviewed changes
modules/SofaMisc/AddResourceRepository.cpp
@@ -0,0 +1,81 @@
#define SOFA_COMPONENT_MISC_ADDRESOURCEREPOSITORY_CPP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the license header here...

modules/SofaMisc/SofaMisc_test/AddResourceRepository_test.cpp
@@ -0,0 +1,71 @@
#include <SofaTest/Sofa_test.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and here :)

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 20, 2017
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Sep 21, 2017
@damienmarchal
Copy link
Contributor

[ci-build]

@damienmarchal
Copy link
Contributor

Thank for adding new features to Sofa and having provided tests with it.
Seem to compile and does not turn the CI in full red.
So let's merge it.

@damienmarchal damienmarchal merged commit 47f4910 into sofa-framework:master Sep 22, 2017
@fredroy fredroy deleted the add_custom_data_repos branch September 22, 2017 12:11
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @damienmarchal @guparan @hugtalbot