Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Clean BaseLoader & Remove un-needed #includes #393

Merged
merged 27 commits into from
Sep 15, 2017
Merged

[all] Clean BaseLoader & Remove un-needed #includes #393

merged 27 commits into from
Sep 15, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Sep 7, 2017 •
edited by guparan
Loading

Hi all,

BaseLoader was implemented in .h.
This is bad so I splitted it into BaseLoader.cpp/h
Then I removed the un-needed includes
Then I updated all the codebase that were missing specific includes.

In case your code does not compile... after this PR then you need to add the include you are missing
(probably fstream or sofa::helper::system::FileRepository)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[Modeler] Propagate the #include changes introduced in (CONT)
15746d8
@damienmarchal
[SofaPython] Propagate the #include changes introduced in (CONT)
a4dca08
@damienmarchal
[Registration] Propagate the #include changes introduced in (CONT)
ca55889
@damienmarchal
[Compilant] Propagate the #include changes introduced in (CONT)
cd4554d
@damienmarchal
[SofaKernel] Propagate the #include changes introduced in (CONT)
dff0cef
@damienmarchal
[SofaLoader] Propagate the #include changes introduced in (CONT)
be6b306
@damienmarchal
[SofaTest] Propagate the #include changes introduced in (CONT)
63928bb
@damienmarchal
[SofaPython] Propagate the #include changes introduced in (CONT)
8b50b9d
@damienmarchal
[runSofa] Propagates the #include changes introduced in (CONT)
3fe10fe
@damienmarchal
[SceneCreator] Propagate the #include changes introduced in (CONT)
6965b77
@damienmarchal
[SofaVolumetricData] Propagate the #include changes introduced in (CONT)
1d6d26d
@damienmarchal
[SofaVolumetricData] Propagate the #include changes introduced in (CONT)
6f20a16
@damienmarchal
[SofaOpenGlVisual] Propagate the #include changes introduced in (CONT)
29ce77d
@damienmarchal
[SofaMiscEngine] Propagate the #include changes introduced in (CONT)
87ab202
@damienmarchal
[SofaConstraint] Propagate the #include changes introduced in (CONT)
8623f62
@damienmarchal
[SofaSparseSolver] Propagate the #include changes introduced in (CONT)
5dc3dc1
@damienmarchal
[SofaGeneralEngin] Update the code to take into account the change in…
4e2caf7 
… (CONT)
@damienmarchal
[SofaGeneralLoader] Update loader to take into account the change in …
eb38684 
…(CONT)
@damienmarchal
[SofaKernel/BaseLoader] Move code from BaseLoader.h to BaseLoader.cpp…
667a72f 
… (CONT)

Fix SpringForceField.inl
@damienmarchal
[SofaKernel/BaseLoader] Move code from BaseLoader.h to BaseLoader.cpp…
f6c0ea0 
… (CONT)

Update files that where using code included from BaseLoader.h.
@damienmarchal
[SofaKernel/BaseLoader] Move code from BaseLoader.h to BaseLoader.cpp
3c2d842
@damienmarchal
[SofaKernel] Remove #include<FileRepository> from .h
4304ea9 
Doing so reduce the graph of dependency (thus re-compilation time).

You may need to fix your code by using
where it is really needed.
@damienmarchal
[SofaGraphComponent] Fix include dependency because of BaseLoader.
819621a
@damienmarchal damienmarchal added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Sep 7, 2017
@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Sep 13, 2017
@guparan guparan removed the pr: status to review To notify reviewers to review this pull-request label Sep 13, 2017
@damienmarchal damienmarchal merged commit 7e76203 into sofa-framework:master Sep 15, 2017
@damienmarchal
Copy link
Contributor Author

It builds, no more failure...it is ready...so let's merge it.

guparan added a commit to mimesis-inria/sofa that referenced this pull request Sep 15, 2017
@guparan
[SofaPython] FIX SofaModule_test compilation
6ccd795 
fstream needs to be included explicitly, see sofa-framework#393
@damienmarchal damienmarchal deleted the cleanBaseLoader branch September 20, 2017 18:33
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
hugtalbot pushed a commit to hugtalbot/plugin.SofaPython2 that referenced this pull request Apr 26, 2020
@guparan
[SofaPython] FIX SofaModule_test compilation
f2abd97 
fstream needs to be included explicitly, see sofa-framework/sofa#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
2 participants
@damienmarchal @guparan