Fix CMakeLists bug on Sofa.ini and installedSofa.ini creation #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LL_RESOURCES_FILES is not checked. See Issue sofa-framework#114
… SOFA_INSTALL_RESOURCES_FILES is set to off.
6 tasks
|
Thanks for the cleaning 😄 |
guparan
added
pr: fast merge
guparan
approved these changes
Jun 6, 2017
hugtalbot
added
the
pr: status to review
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #284 but without the unwanted merge commits
Small fix related to issue #114 .
Have tested the compilation without the flag SOFA_INSTALL_RESOURCES_FILES (which is set by default), Sofa.ini and installedSofa.ini, which are necessary for build and install, are well created.
This PR:
Reviewers will merge only if all these checks are true.