Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] ADD brace initializer to helper::vector class #252

Merged
merged 2 commits into from
Apr 28, 2017
Merged

[SofaKernel] ADD brace initializer to helper::vector class #252

merged 2 commits into from
Apr 28, 2017

Conversation

VannesteFelix
Copy link
Contributor

@VannesteFelix VannesteFelix commented Apr 21, 2017 •
edited by damienmarchal
Loading

This PR add:
Initialization of helper::vector using {}

Example:
helper::vector< double > vec1 = {5,4,7,1,2};
helper::vector<helper::vector< double >> vec2 = {{5,4},{7,1,2}};

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Apr 21, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@damienmarchal
Copy link
Contributor

Hi Felix,

Thank you for you PR. The feature look fine to me, I see no drawback.

@damienmarchal
Copy link
Contributor

[ci-build]

@matthieu-nesme
helper::vector
44e900f 
missing Alloc template parameter
@hugtalbot
Copy link
Contributor

Hi @VannesteFelix

Thank you very much for your contribution.
Could you please add the proper labels on your PR ? Thanks !

@bcarrez bcarrez added the enhancement About a possible enhancement label Apr 25, 2017
@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Apr 26, 2017
@damienmarchal
Copy link
Contributor

[ci-build]

@damienmarchal damienmarchal merged commit adc7d9c into sofa-framework:master Apr 28, 2017
@damienmarchal
Copy link
Contributor

Done.

@damienmarchal damienmarchal deleted the vectorInitializer branch April 28, 2017 20:16
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthieu-nesme matthieu-nesme

Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
7 participants
@VannesteFelix @sofabot @damienmarchal @hugtalbot @guparan @matthieu-nesme @bcarrez