Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBase] Package SofaBaseMechanics #1680

Merged
merged 12 commits into from
Dec 23, 2020
Merged

[SofaBase] Package SofaBaseMechanics #1680

merged 12 commits into from
Dec 23, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 21, 2020

#1633

  • Usual cleaning (pragma, namespaces)
  • remove/reorganize useless includes
  • remove warnings
  • use sofa::Size/sofa::Index
  • fix dependencies
  • use rgbacolor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code NG2: pluginization See https://github.com/sofa-framework/sofa/issues/1527 labels Dec 21, 2020
@fredroy
Copy link
Contributor Author

fredroy commented Dec 21, 2020

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the modularize_base_mechanics branch from e4a9118 to 7dbf6e8 Compare December 23, 2020 09:24
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Dec 23, 2020
@jnbrunet jnbrunet merged commit 50cd75d into sofa-framework:master Dec 23, 2020
jnbrunet pushed a commit that referenced this pull request Dec 23, 2020
@fredroy @jnbrunet
[SofaBase] Package SofaBaseMechanics (#1680)
f5cc82d 
* cmake setup

* clean up

* add component change

* force init()

* use rgbacolor

* remove warnings, use Index/Size

* clean includes

* Fix deps

* update config.cmake.in

* change component version number

* Fix compilation for gcc/clang

(cherry picked from commit 50cd75d)
@guparan guparan added this to the v20.12 milestone Jan 18, 2021
@fredroy fredroy deleted the modularize_base_mechanics branch January 27, 2021 16:12
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnbrunet jnbrunet jnbrunet left review comments

Assignees
No one assigned
Labels
NG2: pluginization See https://github.com/sofa-framework/sofa/issues/1527 pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @jnbrunet @guparan @hugtalbot