Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMisc] Pluginize all modules #1520

Merged
merged 24 commits into from
Oct 21, 2020
Merged

[SofaMisc] Pluginize all modules #1520

merged 24 commits into from
Oct 21, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 8, 2020 •
edited by guparan
Loading

Could not just reopen #1307 because of a force-push after closure 👎

Issue #1306

  • Modularize all SofaMisc*
  • Clean using pragma once/nested namespace
  • rename all macros/file (e.g SOFA_MISC_FEM_API into SOFA_SOFAMISCFEM_API )

Breaking for :

  • code doing initMisc()
  • with scenes requiring components from it and missing the mandatory

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added enhancement About a possible enhancement pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code labels Oct 8, 2020
@damienmarchal
Copy link
Contributor

I'm very enthousiast to see your recent PR @fredroy :)

@fredroy fredroy added the pr: do not squash To merge instead of squash a pull-request label Oct 9, 2020
@fredroy
Copy link
Contributor Author

fredroy commented Oct 9, 2020

[ci-build][with-all-tests]

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 10, 2020
@guparan guparan added the NG2: pluginization See https://github.com/sofa-framework/sofa/issues/1527 label Oct 15, 2020
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 21, 2020
@epernod epernod merged commit 63d8fd0 into sofa-framework:master Oct 21, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@fredroy fredroy deleted the modularize_sofamiscall branch December 10, 2020 16:05
@guparan guparan changed the title [Modularization] SofaMisc* (Revival) [SofaMisc] Pluginize all modules Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement NG2: pluginization See https://github.com/sofa-framework/sofa/issues/1527 pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: do not squash To merge instead of squash a pull-request pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @damienmarchal @epernod @guparan