Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSparseSolver] Move CSparse and metis into SofaSparseSolver #1357

Merged
merged 3 commits into from
May 14, 2020
Merged

[SofaSparseSolver] Move CSparse and metis into SofaSparseSolver #1357

merged 3 commits into from
May 14, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 30, 2020 •
edited by hugtalbot
Loading

As CSparse and metis are only used by SofaSparseSolver module, it was deemed necessary to move these libs into it.
Fix issue #1309

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code STC#9 Simple tasks for STC#5 coding sprint labels Apr 30, 2020
@fredroy
Copy link
Contributor Author

fredroy commented May 3, 2020

[ci-build][with-all-tests]

guparan
guparan reviewed May 6, 2020
View reviewed changes
applications/plugins/SceneCreator/SceneCreatorConfig.cmake.in Outdated
Comment on lines 8 to 10
if(SCENECREATOR_HAVE_SOFASPARSESOLVER)
find_package(SofaSparseSolver REQUIRED)
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCENECREATOR_HAVE_SOFASPARSESOLVER has no value in the scope of this file.
You need to add set(SCENECREATOR_HAVE_SOFASPARSESOLVER @SCENECREATOR_HAVE_SOFASPARSESOLVER@) to transfer the value from the scope of SceneCreator/CMakeLists.txt at configure time.

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 12, 2020
@epernod epernod merged commit 28cb4c7 into sofa-framework:master May 14, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@fredroy fredroy deleted the move_cparse branch June 16, 2020 08:53
@epernod epernod mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan left review comments

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed STC#9 Simple tasks for STC#5 coding sprint
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @epernod