Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping #1319

Merged
merged 1 commit into from
Apr 9, 2020
Merged

[SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping #1319

merged 1 commit into from
Apr 9, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Apr 6, 2020

Adding Edge case should be done using the proper lower topology addEdge mechanisme.

Should fix the scene test error on AddingTetra2TriangleProcess.scn

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod
[Topo] Fix Tetra2TriangleTopologicalMapping Adding Edge case should b…
5a937bc 
…e done using the proper lower addEdge mechanism.
@epernod epernod added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Apr 6, 2020
@epernod epernod self-assigned this Apr 6, 2020
@epernod
Copy link
Contributor Author

epernod commented Apr 6, 2020

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 8, 2020
@damienmarchal damienmarchal merged commit 91ed70e into sofa-framework:master Apr 9, 2020
@epernod epernod deleted the inf_fix_tetra2triangle branch April 29, 2020 08:41
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@guparan guparan changed the title [Topo] Fix Tetra2TriangleTopologicalMapping [SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees

@epernod epernod

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
4 participants
@epernod @hugtalbot @guparan @damienmarchal