Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modeler] FIX link error on Windows #1282

Merged
merged 5 commits into from
Mar 24, 2020
Merged

[Modeler] FIX link error on Windows #1282

merged 5 commits into from
Mar 24, 2020

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Mar 23, 2020

This PR follows #1272 to fix a link error on Windows.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 23, 2020
@guparan guparan requested a review from jnbrunet March 23, 2020 10:20
@guparan guparan changed the title Fix sofamodeler link [Modeler] FIX link error on Windows Mar 23, 2020
@guparan
Copy link
Contributor Author

guparan commented Mar 23, 2020

My fix doesn't seem very effective...
Did work on my machine though 🤔

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Mar 23, 2020
@guparan guparan force-pushed the fix_sofamodeler_link branch from 2d71543 to fff942b Compare March 23, 2020 21:30
@guparan
[Modeler] Move this project out of SofaGui
fff942b 
Modeler (exec) and SofaModeler (lib) are now in a new package : SofaModeler
@jnbrunet jnbrunet merged commit fe5e8e6 into sofa-framework:master Mar 24, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@guparan guparan deleted the fix_sofamodeler_link branch October 29, 2021 08:26
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnbrunet jnbrunet jnbrunet approved these changes

Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
3 participants
@guparan @jnbrunet @hugtalbot