Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSphFluid] Clean, Fix, Update ParticleSink #1195

Merged
merged 11 commits into from
Oct 31, 2019
Merged

[SofaSphFluid] Clean, Fix, Update ParticleSink #1195

merged 11 commits into from
Oct 31, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 25, 2019

Last but not least PR on SPH plugin to restore ParticleSink component.

  • Move all code inside inl file
  • Fix the extern template
  • Add prefix d_ to data
  • Fix global behavior
  • Update the existing basic example scene
  • Add 2 others scenes using Topology changes and OglFluid rendering done in previous PR.

ezgif com-crop

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added location: plugins pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 25, 2019
@epernod epernod self-assigned this Oct 25, 2019
@epernod
Copy link
Contributor Author

epernod commented Oct 25, 2019

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 30, 2019
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Oct 30, 2019
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 30, 2019
@hugtalbot
Copy link
Contributor

I wanted to pass it to ready but centOS seems to have an issue .. maybe nothing ?

@epernod
Copy link
Contributor Author

epernod commented Oct 30, 2019

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Oct 30, 2019
@epernod
Copy link
Contributor Author

epernod commented Oct 31, 2019

nothing ;)

@hugtalbot hugtalbot merged commit 40fff11 into sofa-framework:master Oct 31, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
@epernod epernod deleted the inf_sph_PSource branch March 29, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @hugtalbot @guparan