chore: Add support for remote-repo-url flag [CFG-2085] #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
force-pushed
the
chore/add-remote-repo-url-iac-v2
branch
2 times, most recently
from
51235d5 to
9b18e96
Compare
ipapast
approved these changes
Aug 17, 2022
ofekatr
force-pushed
the
chore/add-remote-repo-url-iac-v2
branch
from
9b18e96 to
fb350fb
Compare
|
this is not going to work with the current snyk-iac-test version. could you make sure to update the checksums again after this PR is merged? https://github.com/snyk/snyk-iac-test/pull/90 |
ofekatr
force-pushed
the
chore/add-remote-repo-url-iac-v2
branch
from
fb350fb to
18e8c87
Compare
Forgot to push after I changed the flag name, thanks for catching this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Add support for
remote-repo-urlflag in the new engine. This flag will override the remote repository URL when sharing results via--report --remote-repo-url=<new-url>.If the
target-nameflag is used too, then the--target-namewill override that for the project name.PR https://github.com/snyk/snyk-iac-test/pull/89 will process the
remote-repo-urlflag insnyk-iac-test.Notes for the reviewer
To test:
snyk-iac-testfrom https://github.com/snyk/snyk-iac-test/pull/89:SNYK_IAC_POLICY_ENGINE_PATH=<path-to-snyk-iac-test> snyk-dev iac test test/fixtures/iac/terraform/sg_open_ssh.tf --experimental --report --remote-repo-url=yoloyolo.SNYK_IAC_POLICY_ENGINE_PATH=<path-to-snyk-iac-test> snyk-dev iac test test/fixtures/iac/terraform/sg_open_ssh.tf --experimental --report --remote-repo-url=oloy --target-name=yoloyolo.More information
CFG-2085