Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE]: v0.9.4 #1566

Merged
merged 1 commit into from
Apr 5, 2020
Merged

[RELEASE]: v0.9.4 #1566

merged 1 commit into from
Apr 5, 2020

Conversation

vincentschen
Copy link
Member

Description of proposed changes

Update CHANGELOG.md + snorkel version.py to 0.9.4.

@vincentschen vincentschen requested a review from henryre April 5, 2020 21:08
henryre
henryre approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change, then lgtm!

CHANGELOG.md Outdated

### [Contributors]

Thanks to @ptrcklv for recent contributions!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1523 was by @rjurney! (I just did some branch cleaning.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 awesome!! updated

@codecov
Copy link

codecov bot commented Apr 5, 2020 •
edited
Loading

Codecov Report

Merging #1566 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1566   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files          56       56           
  Lines        2091     2091           
  Branches      342      342           
=======================================
  Hits         2031     2031           
  Misses         31       31           
  Partials       29       29
Impacted Files Coverage Δ
snorkel/version.py 100.00% <100.00%> (ø)

@lukehsiao
Copy link
Contributor

Will #1565 make it into this release, by chance?

@vincentschen
Copy link
Member Author

Will #1565 make it into this release, by chance?

#1565 will make it into 0.9.5, which we'll cut shortly after 0.9.4!

@lukehsiao
Copy link
Contributor

#1565 will make it into 0.9.5, which we'll cut shortly after 0.9.4!

Amazing. Thank you, Vincent! We will be able to release new version of Fonduer once 0.9.5 is out. This dependency upgrade is going to be super helpful.

@lukehsiao lukehsiao mentioned this pull request Apr 5, 2020
Merged
@vincentschen vincentschen merged commit 4c6bccb into master Apr 5, 2020
@vincentschen vincentschen deleted the release-v0.9.4 branch April 5, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryre henryre henryre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentschen @lukehsiao @henryre