Upgrade pytorch requirement to >=1.2.0 #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentschen
force-pushed
the
vsc-torch1.4
branch
from
db96e41 to
0a909c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 56 56
Lines 2091 2091
Branches 342 342
=======================================
Hits 2031 2031
Misses 31 31
Partials 29 29
|
bhancock8
reviewed
Apr 5, 2020
henryre
reviewed
Apr 5, 2020
requirements.txt
Outdated
| @@ -18,15 +18,14 @@ tqdm>=4.33.0,<5.0.0 | |||
|
|
|||
| # Internal models | |||
| scikit-learn>=0.20.2,<0.22.0 | |||
| torch>=1.1.0,<1.2.0 | |||
| torch>=1.4.0,<2.0.0 | |||
There was a problem hiding this comment.
Is this incompatible with 1.2 and 1.3?
There was a problem hiding this comment.
yes, all tests pass with the older versions 1.2.0 and 1.3.0.
relaxing the requirement to torch>=1.2.0,<2.0.0
vincentschen
force-pushed
the
vsc-torch1.4
branch
from
0a909c4 to
c9a0c85
Compare
vincentschen
changed the title
Merged
henryre
approved these changes
Apr 6, 2020
| @@ -41,9 +41,9 @@ | |||
| "pandas>=0.25.0,<0.26.0", | |||
| "tqdm>=4.33.0,<5.0.0", | |||
| "scikit-learn>=0.20.2,<0.22.0", | |||
| "torch>=1.1.0,<1.2.0", | |||
| "torch>=1.2.0,<2.0.0", | |||
| "tensorboard>=1.14.0,<2.0.0", | |||
There was a problem hiding this comment.
how did we decide on this range?
There was a problem hiding this comment.
I got an import error that looked like this:
ImportError: TensorBoard logging requires TensorBoard with Python summary writer installed. This should be available in 1.14 or above
|
@vincentschen can we update the Test Plan with details from the multiple version tests? |
Yep! Naively, pinned the version to each minor release and ran all unit/integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
torchtorch.utils.tensorboardand removetensorboardXdeplr_scheduler.step()afteroptimizer.step().byte()with.bool()Related issue(s)
Fixes #1558
Test plan
torch==1.2.0, 1.3.0, 1.4.0tox -e {complex,spark}passes withtorch==1.2.0, 1.3.0, 1.4.0Checklist
Need help on these? Just ask!
tox -e complexand/ortox -e sparkif appropriate.