Add failing test #161
Merged
Add failing test #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olepbr
reviewed
Aug 7, 2023
flake8_type_checking/types.py
Outdated
| @@ -11,7 +11,7 @@ class FunctionRangesDict(TypedDict): | |||
| end: int | |||
|
|
|||
| class FunctionScopeImportsDict(TypedDict): | |||
There was a problem hiding this comment.
Given the change from imports to names below, would it perhaps make sense to rename the class, too?
|
Not overly familiar with the codebase, but the change makes sense to me :-) |
When an import name is shadowed by function arguments, we should not raise TC004 errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
Prevents false positive TC004 errors when an import name is shadowed by function arguments.