Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include prefix + in numbers (all lang) #186

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Include prefix + in numbers (all lang) #186

merged 4 commits into from
Jul 10, 2019

Conversation

JohannaSimoens
Copy link
Contributor

issue #169

adrienball
adrienball requested changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@adrienball adrienball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add some training examples for this ?

@JohannaSimoens
Copy link
Contributor Author

yes you're right, done

@adrienball adrienball merged commit 6683a59 into develop Jul 10, 2019
@adrienball adrienball deleted the fix/number-include-plus-prefix branch July 10, 2019 14:41
ClemDoum pushed a commit that referenced this pull request Jul 10, 2019
@JohannaSimoens @ClemDoum
Include prefix + in numbers (all lang) (#186)
c31a547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienball adrienball adrienball approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannaSimoens @adrienball