-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for comparing results with a specific status #75
Conversation
This patch gives the option to compare only sat/unsat results in the compare2 view (the one that allows to select provers from different runs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! A nitpick or two but it's a good idea! :)
src/core/Test_compare.ml
Outdated
@@ -35,6 +36,16 @@ let cmp2sql = function | |||
|
|||
let pp_cmp = Fmt.of_to_string cmp2sql | |||
|
|||
let status_to_string = function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status_to_sql
maybe?
src/core/Test_compare.ml
Outdated
@@ -35,6 +36,16 @@ let cmp2sql = function | |||
|
|||
let pp_cmp = Fmt.of_to_string cmp2sql | |||
|
|||
let status_to_string = function | |||
| `Sat -> {| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the newlines? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, because I copied from cmp2sql
above (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha! 😂 foisted on my own petard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually now that I think about it I believe I am also the one who wrote cmp2sql
😬
Thanks! :) |
This patch gives the option to compare only sat/unsat results in the compare2 view (the one that allows to select provers from different runs).