-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ATLAS as a builtin #336
Conversation
@benjaminrose I fixed the line too long I hope. |
It looks like you are missing a closing |
They are here: http://svo2.cab.inta-csic.es/svo/theory/fps/index.php?id=Misc/Atlas.orange&&mode=browse&gname=Misc&gname2=Atlas So if they can be pulled over to sncosmo.github.io would be great. |
I think I added the needed redirects to the website, sncosmo/sncosmo.github.io@d4c4dca. |
@benjaminrose And I think I got that parentheses. |
@benjaminrose maybe this test just needs to be retriggered? |
New builtins need an update to both the code and the website. I tried to update the website in a slightly different, but I hoped more sustainable, way. It seems to not have worked. I’ll update it the old way soon and then the last test should pass. Once we get that passing, we should be able to merge this PR. |
Thanks @benjaminrose ! |
@benjaminrose Is there anything I can to support getting the tests to pass? |
It looks like the last failure was a stochastic one and unrelated to this PR. I'm rerunning the tests now. |
LGTM |
Thanks @benjaminrose and @kboone ! |
Thanks @kboone for rerunning it. And I am glad that we can use @mcoughlin, sorry for taking a while to get back to this PR. Glad it got the attention it needed. |
Given that ATLAS provides a very popular forced photometry service used by transient folks, having its filters would seem appropriate.
It looks like someone has to add the SVO files to http://sncosmo.github.io/data, but otherwise seems straightforward.