I think this is a subtle Python 3 unicode bug that has completely broken all SALT2 models. 😮

Arising from the fact that in Python 3:

In [3]: b'Salt2ExtinctionLaw.version' == 'Salt2ExtinctionLaw.version'
Out[3]: False

At the very least, the extinction law version is being set incorrectly to v0 instead of v1 in SALT2Source._set_colorlaw_from_file.

I've been avoiding using online data (e.g., the SALT2 data files) in tests, but this is evidence that it is really needed.

Ah, python three unicode, breaking everything yet again. The amount of
grief it caused me when I was trying to fix PolyChord is insane. Is there a
simple work around that I could employ in sncosmo at the moment, or are you
planning on putting a patch out and know the fix?

Cheers

On Wed, Jun 22, 2016 at 5:06 PM, Kyle Barbary notifications@github.com
wrote:

I think this is a subtle Python 3 unicode bug that has completely broken
all SALT2 models. 😮

Arising from the fact that in Python 3:

In [3]: b'Salt2ExtinctionLaw.version' == 'Salt2ExtinctionLaw.version'
Out[3]: False

At the very least, the extinction law version is being set incorrectly to
v0 instead of v1 in SALT2Source._set_colorlaw_from_file.

I've been avoiding using online data (e.g., the SALT2 data files) in
tests, but this is evidence that it is really needed.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#138 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGb5WXy-5QqS3ooJnQ64qexXaNwCMBSuks5qOc4EgaJpZM4I8HJN
.

Can you give master a try now?

Awesome, thanks Kyle

On Thu, Jun 23, 2016 at 1:33 PM, Kyle Barbary notifications@github.com
wrote:

Closed #138 #138 via 612eb34
612eb34
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#138 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AGb5WVUg-vbj-U43Xq7JCvy4cxqxhx9wks5qOu2LgaJpZM4I8HJN
.

Im reinstalling it from git now. Will check the extended model and report back.

Alright, done a basic test, and it didnt fall over like it used to! Cheers