Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Redis storage adapter #23

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Remove Redis storage adapter #23

merged 5 commits into from
Oct 14, 2020

Conversation

bonustrack
Copy link
Member

No description provided.

fforbeck
fforbeck reviewed Oct 13, 2020
View reviewed changes
.env Outdated Show resolved Hide resolved
@fforbeck
Copy link
Contributor

fforbeck commented Oct 13, 2020 •
edited
Loading

@bonustrack
I noticed you have used the KEY keyword to create the indexes for the MySQL tables. Was wondering if we can change all these KEY declarations (https://github.com/balancer-labs/snapshot-hub/blob/208ba37c80419bb866db2dff3db1655b14079606/server/helpers/database/schema.sql#L13) to the INDEX keyword, that will make it compatible with Postgres as well.

bonustrack and others added 2 commits October 14, 2020 02:55
@bonustrack @fforbeck
Update .env
a21b6cf 
Co-authored-by: Felipe Forbeck <fforbeck@gmail.com>
@fforbeck
Make it compatible with Postgres (#25)
cdafafb
@bonustrack bonustrack merged commit 39dece1 into develop Oct 14, 2020
@bonustrack bonustrack deleted the fabien/remove-redis branch October 14, 2020 05:32
jhd2best added a commit to jhd2best/snapshot-hub that referenced this pull request Sep 30, 2021
@jhd2best
Merge pull request snapshot-labs#23 from jhd2best/harmony-spaces
8fff918 
update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fforbeck fforbeck fforbeck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonustrack @fforbeck