Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for torchmetrics and latest pytorchlightning>=2.0 #421

Merged
merged 13 commits into from
Apr 14, 2023
Merged

fix for torchmetrics and latest pytorchlightning>=2.0 #421

merged 13 commits into from
Apr 14, 2023

Conversation

puririshi98
Copy link
Contributor

No description provided.

@weihua916 weihua916 requested a review from rusty1s April 4, 2023 05:54
weihua916
weihua916 reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also apply the same change to examples/lsc/mag240m/rgnn.py?

examples/lsc/mag240m/gnn.py Show resolved Hide resolved
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
weihua916
weihua916 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, thanks! Will have @rusty1s have another pass.

examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
rusty1s
rusty1s approved these changes Apr 10, 2023
View reviewed changes
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
weihua916
weihua916 reviewed Apr 12, 2023
View reviewed changes
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
examples/lsc/mag240m/rgnn.py Outdated Show resolved Hide resolved
weihua916
weihua916 reviewed Apr 13, 2023
View reviewed changes
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
examples/lsc/mag240m/gnn.py Outdated Show resolved Hide resolved
@puririshi98
Copy link
Contributor Author

@rusty1s @weihua916 anything else needed?

@weihua916 weihua916 merged commit 614eea3 into snap-stanford:master Apr 14, 2023
@weihua916
Copy link
Contributor

Perfect, merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihua916 weihua916 weihua916 approved these changes

@rusty1s rusty1s rusty1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puririshi98 @weihua916 @rusty1s