Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating @standardRegionalEndpoints nodes #2179

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix creating @standardRegionalEndpoints nodes #2179

merged 1 commit into from
Mar 12, 2024

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Mar 11, 2024

Background

  • What do these changes do?
    Fixes multiple issues serializing the @standardRegionalEndpoints trait.
  • Why are they important?
    If not fixed, serializing this trait may include incorrect values.

Testing

  • How did you test these changes?
    Added a test case.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kstich kstich requested a review from a team as a code owner March 11, 2024 21:49
@kstich kstich requested a review from milesziemer March 11, 2024 21:49
@kstich kstich merged commit 3d72963 into main Mar 12, 2024
11 checks passed
@kstich kstich deleted the standardregionalendpointstrait_fix branch March 12, 2024 04:33
sugmanue added a commit that referenced this pull request Mar 19, 2024
@sugmanue
Removed #2179, There's no public facing change for it
7307c81
sugmanue added a commit that referenced this pull request Mar 19, 2024
@sugmanue
Put back #2179, and remove #2171, there's no public facing change for it
fe4eb5b
sugmanue added a commit that referenced this pull request Mar 19, 2024
@sugmanue
Bump version to 1.46.0 (#2197)
20b7f63 
* Bump version to 1.46.0

* Removed #2179, There's no public facing change for it

* Put back #2179, and remove #2171, there's no public facing change for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFossAWS AndrewFossAWS AndrewFossAWS approved these changes

@sugmanue sugmanue sugmanue approved these changes

@milesziemer milesziemer Awaiting requested review from milesziemer milesziemer is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kstich @sugmanue @AndrewFossAWS