Fix indentation when formatting text blocks #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Jul 21, 2023
| // Dispersing the lines of the text block preserves any indentation applied from formatting parent | ||
| // nodes. | ||
| List<Doc> lines = Arrays.stream(tree.concatTokens() | ||
| .split(System.lineSeparator())) |
There was a problem hiding this comment.
This belongs on the line above, as it's an operation on the result of concatTokens() and not on the result of Arrays.stream().
Updates the formatter to indent the node value of a node kvp when they are text blocks. A test case was added for a text block as the node value of a node kvp, and a test case was updated for when text blocks are in traits.
milesziemer
force-pushed
the
fix-text-block-formatting
branch
from
69209ea to
3d9dff6
Compare
kstich
approved these changes
Jul 21, 2023
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
Updates the formatter to indent the node value of a node kvp when they are text blocks. A test case was added for a text block as the node value of a node kvp, and a test case was updated for when text blocks are in traits.
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Updates the formatter to indent the node value of a node kvp when they are text blocks. A test case was added for a text block as the node value of a node kvp, and a test case was updated for when text blocks are in traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the formatter to indent the node value of a node kvp when they are text blocks.
A test case was added for a text block as the node value of a node kvp, and a test case was updated for when text blocks are in traits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.