Refactor CLI to remove --severity from some commands #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some commands don't need the severity option and should instead only show validation events if the command fails. This includes the ast and select commands. To make this work, I refactored several CLI classes: * Add a shared ModeBuilder abstraction to cleanup the old utility code. This class now uses a Validator.Mode to indicate how validation is reported, decoupling arguments from the shared validation abstraction. * Move --discover and --discover-classpath to DiscoveryOptions * Move --severity to SeverityOption so it's more granular * Add the ability to check for receivers on Arguments * Add the ability to remove receivers from Arguments * Add the ability to get positional arguments more than once * Can now add/remove argument receivers in ClasspathCommand subclasses
JordonPhillips
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commands don't need the severity option and should instead only show validation events if the command fails. This includes the ast and select commands. Neither command should allow a custom severity, and they should only show validation events when the model can't be loaded (i.e., DANGER or ERROR events). To make this work, I refactored several CLI classes:
This makes the current state of arguments:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.