Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon Section added in Expereince Page #842

Merged
merged 3 commits into from
Jul 4, 2021
Merged

Hackathon Section added in Expereince Page #842

merged 3 commits into from
Jul 4, 2021

Conversation

RituCs
Copy link
Contributor

@RituCs RituCs commented Jun 30, 2021

Fixed issue #748 and fulfilled all the requirements.

@vercel
Copy link

vercel bot commented Jun 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smaranjitghose/awesome-portfolio-websites/7XXDR8cYj1oAzhj4U1FLhU71WuyU
✅ Preview: https://awesome-portfolio-websites-git-fork-ritucs-tmp-smaranjitghose.vercel.app

@github-actions github-actions bot added the LGMSOC21 Let's Grow More Summer of Code 2021 label Jun 30, 2021
@smaranjitghose
Copy link
Owner

smaranjitghose commented Jun 30, 2021

  • Highly unresponsive in mobile screens

mobile_view

  • For laptop screens, it almost sticks over the footer
  • Very little space between the SubHeading and the Carousel

The Color of the scrollbar of the timeline should be the same as that of the headings of the page

  • I had specifically mentioned the above point so that this addition does not look weird

@RituCs
Copy link
Contributor Author

RituCs commented Jun 30, 2021

* Highly unresponsive in mobile screens

Done

mobile_view

* For laptop screens, it almost sticks over the footer

Done

* Very little space between the SubHeading and the Carousel

is it Heading or SubHeading ? I don't get this . Please explain this.

The Color of the scrollbar of the timeline should be the same as that of the headings of the page

* I had specifically mentioned the above point so that this addition does not look weird

Sorry for the color of scrollbar. is this #7E7E7E or #0E49B5 ? I am confused what's the exact heading of the page.
Thanks!

@RituCs
Copy link
Contributor Author

RituCs commented Jul 1, 2021

Screenshot from 2021-07-01 23-35-43
Please check this . Is it ok ? I already asked my doubt but tried to fix as per my understanding. Thanks!

@smaranjitghose
Copy link
Owner

* Highly unresponsive in mobile screens

Done

mobile_view

* For laptop screens, it almost sticks over the footer

Done

* Very little space between the SubHeading and the Carousel

is it Heading or SubHeading ? I don't get this . Please explain this.

The Color of the scrollbar of the timeline should be the same as that of the headings of the page

* I had specifically mentioned the above point so that this addition does not look weird

Sorry for the color of scrollbar. is this #7E7E7E or #0E49B5 ? I am confused what's the exact heading of the page.
Thanks!

  • The subheading "Hackathon Experience", Heading is always the one on the top like "My Experience"
  • Inspect and check the current version whenever in doubt😅. #4e00bb

@smaranjitghose
Copy link
Owner

Screenshot from 2021-07-01 23-35-43
Please check this . Is it ok ? I already asked my doubt but tried to fix as per my understanding. Thanks!

Ya. Push the changes in a squash commit. I'll review it

@smaranjitghose smaranjitghose added the 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. label Jul 2, 2021
@smaranjitghose
Copy link
Owner

  • The subheading gets hidden behind the carousel in mobile screens:
    Experience_Page


dd

  • Change the color of the buttons and toggle/scroll to that of the scroll bar here

  • Remove the orange layer over the images

Experience_Page_2

  • Put some comments in the CSS file to improve the documentation of your code.

Please do incorporate these basic changes asap and tag me. The rest of the PR is awesome. Looking forward to merging this soon enough!

@RituCs
Copy link
Contributor Author

RituCs commented Jul 3, 2021

Screenshot from 2021-07-03 15-39-01

* Change the color of the buttons and toggle/scroll to that of the scroll bar [here](https://portfolio.smaranjitghose.com/)

I have changed the color of the buttons but again I could not understand which toggle/scroll you want to mention .Is it header section's toggle?
@smaranjitghose

@smaranjitghose
Copy link
Owner

This works. Make the changes

@RituCs
Copy link
Contributor Author

RituCs commented Jul 3, 2021

This works. Make the changes

Done @smaranjitghose .

@@ -1,3 +1,4 @@
@import url('https://fonts.googleapis.com/css?family=Fira+Sans:400,500,600,700,800');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Poppins only

@smaranjitghose smaranjitghose merged commit 192eb35 into smaranjitghose:master Jul 4, 2021
@pr-triage pr-triage bot added the PR: merged label Jul 4, 2021
anuprshetty pushed a commit to anuprshetty/anuprshetty.github.io that referenced this pull request Jan 1, 2025
Hackathon Section added in Expereince Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. LGMSOC21 Let's Grow More Summer of Code 2021 PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants