Add vertx-based exporters #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
2 times, most recently
from
f3c3d94 to
17247f5
Compare
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
2 times, most recently
from
c27b844 to
a859d58
Compare
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
from
a859d58 to
29c50a4
Compare
|
@radcortez I think this is ready for review when you get a chance. |
radcortez
reviewed
Nov 13, 2023
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
2 times, most recently
from
1edc5a1 to
0d2cb5f
Compare
radcortez
requested changes
Nov 13, 2023
.../main/java/io/smallrye/opentelemetry/implementation/exporters/VertxHttpExporterProvider.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/smallrye/opentelemetry/api/OpenTelemetryConfig.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/smallrye/opentelemetry/api/OpenTelemetryConfig.java
Outdated
Show resolved
Hide resolved
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
2 times, most recently
from
1220159 to
afe73f1
Compare
radcortez
reviewed
Nov 15, 2023
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
from
afe73f1 to
03bf6c1
Compare
|
@radcortez Requested changes made and pushed. |
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
from
03bf6c1 to
38b763c
Compare
|
@radcortez I've added some testing for the new exporters. Please give this a look and let me know what you think. |
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
3 times, most recently
from
24ad79e to
c102517
Compare
Add fork of Quarkus vertx-based exporters Create new module for exporters Add testcontainer-based testing of new exporters
jasondlee
force-pushed
the
vertx_quarkus_fork
branch
from
c102517 to
60508e1
Compare
radcortez
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vertx-based exporters (forked from Quarkus) to avoid use of Kotlin-based equivalents from upstream