-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpreter: Add support for save/load of enums #3012
Interpreter: Add support for save/load of enums #3012
Conversation
Thank you for your contribution and the pull request. I really appreciate your effort. I must say, your idea of serializing using To achieve this, I believe there are two possibilities that we can explore:
From looking at the code, it appears that these modifications would not be required in many places:
(As a side node, we might want to change Once again, I want to express my gratitude for your pull request. I hope my suggestions and explanations make sense to you. Please let me know if you have any further questions or if there's anything else I can assist you with. |
0f41928
to
a6a2f5b
Compare
I went for the first solution. I'm not entirely sure about the error handling, but it works. |
By the way, thank you for the detailed briefing on how to do it well ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! this looks good. I'll merge tomorrow.
Fixes for #3011
This uses a hack to serialize enum values in string format, maybe this can be made in a better way.