Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slintpad: Move into tools/slintpad #2435

Merged
merged 2 commits into from
Mar 29, 2023
Merged

slintpad: Move into tools/slintpad #2435

merged 2 commits into from
Mar 29, 2023

Conversation

hunger
Copy link
Member

@hunger hunger commented Mar 29, 2023

  • Add "slintpad" to cspell white list for all languages
  • Mention online_editor to slintpad rename in CHANGELOG
  • Move tools/online_editor into tools/slintpad
  • Update github actions accordingly

With this chaneg I can not find "online.editor" in our sources with some obvious exceptions (old changelog entries and the README saying that "slintpad is an online editor"), so I think this PR is pretty complete.

ogoffart
ogoffart reviewed Mar 29, 2023
View reviewed changes
internal/compiler/expression_tree.rs Outdated Show resolved Hide resolved
.github/actions/test-online-editor/action.yaml Outdated Show resolved Hide resolved
.github/actions/test-online-editor/action.yaml Outdated Show resolved Hide resolved
tools/slintpad/src/worker/lsp_worker.ts Outdated Show resolved Hide resolved
@hunger @ogoffart
Apply suggestions from code review
3a9ea91 
Co-authored-by: Olivier Goffart <olivier@woboq.com>
@hunger hunger merged commit de0dc20 into slint-ui:master Mar 29, 2023
@hunger hunger deleted the sp_move branch March 29, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunger @ogoffart