-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update license to v1.2 #1711
Update license to v1.2 #1711
Conversation
aurindam
commented
Oct 6, 2022
- Update Slint License Agreement
- Update README.md (root)
- Update LICENSE.md (root)
- Update FAQ.md (root)
I only added formal/formatting things... feel free to ignore:-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment in the FAQ.
README.md
Outdated
@@ -8,46 +8,49 @@ | |||
[![REUSE status](https://api.reuse.software/badge/github.com/slint-ui/slint)](https://api.reuse.software/info/github.com/slint-ui/slint) | |||
[![Discussions](https://img.shields.io/github/discussions/slint-ui/slint)](https://github.com/slint-ui/slint/discussions) | |||
|
|||
Slint is a toolkit to efficiently develop fluid graphical user interfaces for any display: embedded devices and desktop applications. We support multiple programming languages, such as | |||
Rust, C++, and JavaScript. | |||
Slint is a toolkit to efficiently design, develop and deploy responsive apps on any screen. Frontends built with Slint can be easily integrated with backends written in different programming languages such as C/C++, Rust, and JavaScript. Slint is developed by SixtyFPS GmbH together with the community. We invite you to use Slint and be part of its community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting introduction of frontend and backend here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to changes in the wording :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reading this, I think the previously sentence was simpler and easier to read. Introducing terms such as "backend" and "frontend" seems tempting from a technical perspective, but it also creates ambiguity for people coming from the web for example. Does this mean that the backend runs on a server and Slint UI runs elsewhere? (traditionally there's a host boundary between those).
Since this is the very first sentence of the README, simplicity and clarify wins over the "feature" that we support a frontend and backend separation. If anything, I think that could be a bullet point under "features" somewhere.
I suggest to go back to the old wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Design vs. Logic?
Slint is a toolkit to efficiently design, develop and deploy responsive apps on any screen. Frontends built with Slint can be easily integrated with backends written in different programming languages such as C/C++, Rust, and JavaScript. Slint is developed by SixtyFPS GmbH together with the community. We invite you to use Slint and be part of its community. | |
Slint is a toolkit to efficiently design, develop and deploy responsive apps on any screen. User interface design built with Slint can be easily integrated with logic written in different programming languages such as C++, Rust, and JavaScript. Slint is developed by SixtyFPS GmbH together with the community. We invite you to use Slint and be part of its community. |
I'm also unsure if we should mention SixtyFPS GmbH so early in the introduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted back to old wording. Added one sentence "We invite you to use Slint and be part of its community."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good now
(please squash the commit while merging)
Update to v1.2
1. reformatted document to break at 80 characters 2. included review changes requested by tobias 3. moved support section out of license agreement
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
105f891
to
3951d08
Compare
Update to v1.2 and updated the README and FAQ.