Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(search): correct credentials for docsearch #95

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 17, 2022

Not 100% sure if the index name and filters are right, but it's a v3 config, so requires appId

Not 100% sure if the index name and filters are right, but it's a v3 config, so requires appId
@chuckmeyer
Copy link

chuckmeyer commented Oct 17, 2022

@Haroenv et al -- With the APP ID in place in your preview, I can see the network traffic round trip through Algolia and search results (hits) in the responses. However, those responses are getting rendered as blank list items (li) in the preview.

I'm wondering if they are getting corrupted by this transformation function.

Could anyone with a deeper understanding of how that component is built take a look? Any chance we can just temporarily disable it in this PR to confirm it's the issue and not DocSearch itself?

@antfu antfu merged commit ecd8bf0 into slidevjs:main Oct 18, 2022
@antfu
Copy link
Member

antfu commented Oct 18, 2022

Thank you for investigating! I have pushed a commit to update the component and it should work now: 550ff2f

@Haroenv Haroenv deleted the patch-1 branch October 18, 2022 08:13
@Haroenv
Copy link
Contributor Author

Haroenv commented Oct 18, 2022

Perfect, I had something fairly similar locally, but it still didn't render, glad you found it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants