Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQLProfile: quote column names in insertOrUpdate statement #2912

Merged
merged 2 commits into from
Apr 10, 2024
Merged

MySQLProfile: quote column names in insertOrUpdate statement #2912

merged 2 commits into from
Apr 10, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Mar 10, 2024

Closes #2910.

It would be nice to write a test for this functionality. I'm unfamiliar with Slick's codebase, so where is the best place to add a test?

@github-actions GitHub Actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@nafg
Copy link
Member

nafg commented Mar 10, 2024

@mdedetrich any idea why MiMa is reporting these incompatibilities? #2912 (comment)

@jkugiya
Copy link
Contributor

jkugiya commented Mar 11, 2024

iRevive#1

@nafg @iRevive
Sorry for the inconvenience. I have fixed it so that the test fails in the original implementation in the buggy case, so you can take it in if you like.

@jkugiya
Copy link
Contributor

jkugiya commented Mar 11, 2024

@nafg

@mdedetrich any idea why MiMa is reporting these incompatibilities? #2912 (comment)

I don't know why, but the same report was output when I output the report after publishLocal of the main branch. I think it is a plugin issue.

$ sbt shell
sbt:slick-root> clean
sbt:slick-root> publishLocal
sbt:slick-root> set every CompatReportPlugin.previousRelease := Some("3.5.0")
sbt:slick-root> writeCompatReportToGitHubOutput

@iRevive
Copy link
Contributor Author

iRevive commented Mar 11, 2024

iRevive#1

@nafg @iRevive Sorry for the inconvenience. I have fixed it so that the test fails in the original implementation in the buggy case, so you can take it in if you like.

thanks!

@mdedetrich
Copy link
Contributor

@mdedetrich any idea why MiMa is reporting these incompatibilities? #2912 (comment)

I am guessing that since the inliner is enabled in CI its actually doing the work its meant to and inlining the classes and I forgot to add these cases to MiMa when creating the original PR.

Ill make a PR to solve this

@mdedetrich mdedetrich mentioned this pull request Mar 11, 2024
Merged
nafg added a commit that referenced this pull request Mar 26, 2024
@nafg
Add slick-compat-collection to MiMa exclude filter (#2913)
5ddbf75 
Meant to solve
#2912 (comment)
@github-actions GitHub Actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@nafg Mergify
Copy link
Member

nafg commented Apr 9, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2024

rebase

✅ Branch has been successfully rebased

@nafg nafg force-pushed the mysql-insertOrUpdate-fix branch from 39e3e5a to 408178b Compare April 9, 2024 19:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Incompatible changes

slick

3 changes since 3.5.1-pre.8.45ca8b14

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@mergify mergify bot merged commit 4a451d3 into slick:main Apr 10, 2024
17 checks passed
@nafg nafg added bug release-highlight A highlight of the release labels Apr 14, 2024
@nafg nafg added this to the 3.5.1 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafg nafg nafg approved these changes

Assignees
No one assigned
Labels
bug release-highlight A highlight of the release
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.

Slick 3.5.0, MariaDB, insertOrUpdate fails with You have an error in your SQL syntax
4 participants
@iRevive @nafg @jkugiya @mdedetrich