Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DBIO#void, DBIO#as, DBIO.unit #2911

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Add DBIO#void, DBIO#as, DBIO.unit #2911

merged 1 commit into from
Apr 14, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Mar 9, 2024 •
edited
Loading

A few convenience methods from the #2878.

@github-actions GitHub Actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

nafg
nafg requested changes Mar 10, 2024
View reviewed changes
slick/src/main/scala/slick/dbio/DBIOAction.scala Outdated Show resolved Hide resolved
slick/src/main/scala/slick/dbio/DBIOAction.scala Outdated Show resolved Hide resolved
@iRevive iRevive force-pushed the feature/dbio-syntax branch 2 times, most recently from b9e3225 to 88bbbcc Compare March 10, 2024 20:14
@iRevive
Copy link
Contributor Author

iRevive commented Mar 10, 2024

I've addressed the feedback.

nafg
nafg approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@nafg nafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@nafg Mergify
Copy link
Member

nafg commented Apr 9, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 9, 2024

rebase

✅ Branch has been successfully rebased

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Incompatible changes

slick

3 changes since 3.5.1-pre.8.45ca8b14

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@github-actions GitHub Actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.1-pre.22.172275e6

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@mergify mergify bot merged commit 95763e5 into slick:main Apr 14, 2024
13 of 16 checks passed
@iRevive iRevive deleted the feature/dbio-syntax branch April 14, 2024 07:47
@nafg nafg linked an issue May 30, 2024 that may be closed by this pull request
Conveniences that could be added to DBIO #2878
Open
4 tasks
@nafg nafg added improvement release-highlight A highlight of the release labels Aug 2, 2024
@nafg nafg added this to the 3.5.2 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafg nafg nafg approved these changes

Assignees
No one assigned
Labels
improvement release-highlight A highlight of the release
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

Conveniences that could be added to DBIO
2 participants
@iRevive @nafg