Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit type #2838

Merged
merged 1 commit into from
Oct 15, 2023
Merged

add explicit type #2838

merged 1 commit into from
Oct 15, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 13, 2023

@github-actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0-pre.92.fd46cbbf

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@github-actions
Copy link
Contributor

Incompatible changes

slick

3 changes since 3.5.0-pre.92.fd46cbbf

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version

@xuwei-k xuwei-k marked this pull request as ready for review October 13, 2023 12:46
nafg
nafg approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@nafg nafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 62021a0 into slick:main Oct 15, 2023
13 of 14 checks passed
@xuwei-k xuwei-k deleted the explicit-type-2 branch October 15, 2023 10:22
@nafg nafg added this to the 3.5.0 milestone Nov 20, 2023
@nafg nafg added the refactor label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafg nafg nafg approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @nafg