Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace filter on aggregates with CASE, closes #2235 #2832

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Replace filter on aggregates with CASE, closes #2235 #2832

merged 1 commit into from
Oct 19, 2023

Conversation

OlegYch
Copy link
Contributor

@OlegYch OlegYch commented Sep 14, 2023 •
edited by nafg
Loading

Fix a case when filtered aggregate produces runtime exception by interpreting it with CASE expressions.

Closes #2235

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@OlegYch
Copy link
Contributor Author

OlegYch commented Sep 14, 2023

there is probably a better way to do it, but I'm not really familiar with the codebase

@OlegYch OlegYch force-pushed the fix-2235 branch 2 times, most recently from f0a1496 to bb2133d Compare September 14, 2023 18:25
@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

1 similar comment
@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.88.a189ac54

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap DirectMissingMethodProblem

method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.92.fd46cbbf

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap VirtualStaticMemberProblem

non-static method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates is static in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@nafg
Copy link
Member

nafg commented Oct 15, 2023 •
edited
Loading

No one is, and it looks like well-written code, but can you explain better what this PR does? (Edit the description)

@nafg
Copy link
Member

nafg commented Oct 15, 2023

Since the PR links are part of the generated GitHub release notes, I consider descriptions of important PRs to be an important form of documentation

@OlegYch
Copy link
Contributor Author

OlegYch commented Oct 19, 2023

@nafg done

@nafg nafg linked an issue Oct 19, 2023 that may be closed by this pull request
group by with map to use filter on group and calculate length fails #2235
Closed
@nafg
Copy link
Member

nafg commented Oct 19, 2023

Thanks!

@github-actions
Copy link
Contributor

Incompatible changes

slick

5 changes since 3.5.0-pre.104.a5dd96f7

Code changes

Incompatibility Symbol Problem
Backward slick.compat.collection.package MissingClassProblem

class slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$ MissingClassProblem

object slick.compat.collection.package does not have a correspondent in current version
Backward slick.compat.collection.package$JavaConverters$ MissingClassProblem

object slick.compat.collection.package#JavaConverters does not have a correspondent in current version
Backward slick.compiler.CreateAggregates.inlineMap VirtualStaticMemberProblem

non-static method inlineMap(slick.ast.Aggregate)slick.ast.Aggregate in class slick.compiler.CreateAggregates is static in current version
Backward slick.compiler.CreateAggregates.liftAggregates VirtualStaticMemberProblem

non-static method liftAggregates(slick.ast.Node,slick.ast.TermSymbol)scala.Tuple2 in class slick.compiler.CreateAggregates is static in current version

@mergify mergify bot merged commit d463f34 into slick:main Oct 19, 2023
14 checks passed
@nafg nafg added this to the 3.5.0 milestone Nov 20, 2023
@nafg nafg added the bug label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafg nafg nafg approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

group by with map to use filter on group and calculate length fails
2 participants
@OlegYch @nafg