Fix skirt/Brim #4669
Merged
Fix skirt/Brim #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Z coordinates) to Print and prime it with make_brim so it can be used in PrintGCode. Updated test to correctly verify skirt is generated for one and multiple objects.
…l is not generated yet (segfaults).
lordofhyphens
added
the
Code Cleanup/Refactoring
lordofhyphens
requested review from
alranel,
TheThirdOne,
ledvinap and
supermerill
|
✅ Build Slic3r 1.3.0-master-2207 completed (commit 2b601619c6 by @lordofhyphens) |
|
It's not clear to me what issue required to expose |
|
Tests were failing and I tracked it down to that logic. skirt_height_z was never actually used for anything outside of that method. Moreover, skirt_height is in layers and the index for the map was in scaled mm so the logic in PrintGCode::process() wouldn't do anything for the third logic. The net effect is that only the first layer got a skirt. |
alranel
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've finished porting the tests from
t/skirt_brim.tand found/fixed some bugs along the way.